Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use probe-cli@v3.18.1 #524

Merged
merged 5 commits into from
Jul 24, 2023
Merged

chore: use probe-cli@v3.18.1 #524

merged 5 commits into from
Jul 24, 2023

Conversation

bassosimone
Copy link
Contributor

Part of ooni/probe#2503

@bassosimone
Copy link
Contributor Author

I am trying to figure out why the CI checks fail here.

@bassosimone
Copy link
Contributor Author

bassosimone commented Jul 24, 2023 •
edited
Loading

I am starting to understand the issue. These symbols are missing:

 Testing failed:
	Undefined symbol: _res_9_nclose
	Undefined symbol: _res_9_ninit
	Undefined symbol: _res_9_nsearch
	Testing cancelled because the build failed.

I am wondering why. We incremented the Go version we're using so this may be the reason as documented by the following go/mobile issue: golang/go#58416. It seems I need to add libresolv.tbd as a link-time dependency.

@bassosimone bassosimone merged commit abaf66c into master Jul 24, 2023
@bassosimone bassosimone deleted the release/3.18 branch July 24, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone