Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix default value 0 is a string type #299

Conversation

haoqing0110
Copy link
Member

Summary

Fix the below error when MaxFailures field is not defined and use the default value.

E1127 07:23:43.074771       1 base_controller.go:266] "addon-configuration-controller" controller failed to sync "managed-serviceaccount", err: failed to parse the provided maxFailures: '0' is an invalid maximum threshold value: string is not a percentage

Related issue(s)

Fixes #

Signed-off-by: haoqing0110 <qhao@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 November 27, 2023 08:13
@haoqing0110 haoqing0110 changed the title fix default value 0 is a string type 🐛 fix default value 0 is a string type Nov 27, 2023
@haoqing0110
Copy link
Member Author

/assign @qiujian16 @serngawy @dhaiducek

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6587397 into open-cluster-management-io:main Nov 27, 2023
10 of 11 checks passed
@haoqing0110 haoqing0110 deleted the br_fix-default0 branch November 27, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants