Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix default value 0 is a string type #299

Merged
merged 1 commit into from
Nov 27, 2023
Merged

🐛 fix default value 0 is a string type #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions addon/v1alpha1/0000_00_addon.open-cluster-management.io_clustermanagementaddons.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number
of clusters in the current rollout that can fail
before proceeding to the next rollout. MaxFailures
Expand Down Expand Up @@ -249,7 +249,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number
of clusters in the current rollout that can fail
before proceeding to the next rollout. MaxFailures
Expand Down Expand Up @@ -335,7 +335,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number
of clusters in the current rollout that can fail
before proceeding to the next rollout. MaxFailures
Expand Down
2 changes: 1 addition & 1 deletion cluster/v1alpha1/types_rolloutstrategy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ type RolloutConfig struct {
// Default is that no failures are tolerated.
// +kubebuilder:validation:Pattern="^((100|[0-9]{1,2})%|[0-9]+)$"
// +kubebuilder:validation:XIntOrString
// +kubebuilder:default="0"
// +kubebuilder:default=0
// +optional
MaxFailures intstr.IntOrString `json:"maxFailures,omitempty"`
// Timeout defines how long the workload applier controller will wait until the workload reaches a
Expand Down
6 changes: 3 additions & 3 deletions work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number of
clusters in the current rollout that can fail before
proceeding to the next rollout. MaxFailures is only
Expand Down Expand Up @@ -435,7 +435,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number of
clusters in the current rollout that can fail before
proceeding to the next rollout. MaxFailures is only
Expand Down Expand Up @@ -519,7 +519,7 @@ spec:
anyOf:
- type: integer
- type: string
default: "0"
default: 0
description: MaxFailures is a percentage or number of
clusters in the current rollout that can fail before
proceeding to the next rollout. MaxFailures is only
Expand Down
Loading