Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow custom signer signingCA to specify namespace in addOnTemplate #350

Merged
merged 1 commit into from
Dec 9, 2024
Merged

✨ Allow custom signer signingCA to specify namespace in addOnTemplate #350

merged 1 commit into from
Dec 9, 2024

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Dec 6, 2024

Summary

Related issue(s)

open-cluster-management-io/ocm#688

Fixes #

@zhujian7 zhujian7 changed the title WIP: Allow Custom Signer signingCA to Specify Namespace in AddOnTemplate WIP: Allow custom signer signingCA to specify namespace in addOnTemplate Dec 6, 2024
@zhujian7 zhujian7 marked this pull request as ready for review December 6, 2024 02:53
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 December 6, 2024 02:53
@zhujian7
Copy link
Member Author

zhujian7 commented Dec 6, 2024

/cc @mikeshng

@openshift-ci openshift-ci bot requested a review from mikeshng December 6, 2024 02:53
@zhujian7 zhujian7 changed the title WIP: Allow custom signer signingCA to specify namespace in addOnTemplate ✨ Allow custom signer signingCA to specify namespace in addOnTemplate Dec 6, 2024
@zhujian7
Copy link
Member Author

zhujian7 commented Dec 6, 2024

/cc @qiujian16

mikeshng
mikeshng approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Zhu Jian! Exactly what I needed!

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2024
@qiujian16
Copy link
Member

@zhujian7 I think addon manager will not by default has secret access permission for any ns? It has to be added on demand, right?

@zhujian7
Copy link
Member Author

zhujian7 commented Dec 9, 2024

@zhujian7 I think addon manager will not by default has secret access permission for any ns? It has to be added on demand, right?

yes, the developer needs to ensure the addon-manger has the permission. I have added on the field comment

@qiujian16
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b62746a into open-cluster-management-io:main Dec 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshng mikeshng mikeshng approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhujian7 @qiujian16 @mikeshng