Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Signer signingCA to Specify Namespace in AddOnTemplate #688

Closed
mikeshng opened this issue Nov 8, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@mikeshng
Copy link
Member

mikeshng commented Nov 8, 2024

Describe the enhancement
In the current AddOnTemplate API, the SigningCARef does not allow for specifying a namespace value. This means the signing CA secret must be in the open-cluster-management-hub namespace where the addon-manager-controller resides.

In some cases, such as when the argocd-agent principal deployment needs to leverage the signing CA secret, the current restriction forces users to place the argocd-agent deployment in the open-cluster-management-hub namespace instead of its intended argocd namespace.

Requesting an enhancement to add a namespace field in SigningCARef, allowing it to reference a signing CA secret in a specified namespace. Users are still required for granting the necessary RBAC permissions (same as now).

@mikeshng mikeshng added the enhancement New feature or request label Nov 8, 2024
@mikeshng
Copy link
Member Author

mikeshng commented Nov 8, 2024

CC @qiujian16 @zhujian7 @xuezhaojun

@zhujian7
Copy link
Member

@mikeshng This feature has been implemented, I will close this issue, feel free to have a try.
/close

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@zhujian7: Closing this issue.

In response to this:

@mikeshng This feature has been implemented, I will close this issue, feel free to have a try.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this as completed Dec 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in OCM releases Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants