Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update provider object eval, T -> Structure #54

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Aug 28, 2022

I neglected to change T -> Structure in the FeatureProvider interface (I only got the Features interface which corresponds to the evaluation API) in #51. T is so permissive, that it was easy to miss since there wasn't compilation errors.

We certainly want the type in the provider to match the evaluation API.

Since this just changes generics, I believe there is no runtime changes here.

Signed-off-by: Todd Baert <toddbaert@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #54 (3cf5a6f) into main (405e812) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #54   +/-   ##
=========================================
  Coverage     89.60%   89.60%           
  Complexity      145      145           
=========================================
  Files            19       19           
  Lines           327      327           
  Branches          6        6           
=========================================
  Hits            293      293           
  Misses           25       25           
  Partials          9        9           
Flag Coverage Δ
unittests 89.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/dev/openfeature/javasdk/FeatureProvider.java 100.00% <ø> (ø)
...ain/java/dev/openfeature/javasdk/NoOpProvider.java 96.55% <100.00%> (ø)
...ava/dev/openfeature/javasdk/OpenFeatureClient.java 97.53% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert merged commit 52c9730 into main Aug 28, 2022
@toddbaert toddbaert deleted the fix/update-provider branch August 28, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants