Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decomp some of res to get started #439

Merged
merged 6 commits into from
May 21, 2021
Merged

decomp some of res to get started #439

merged 6 commits into from
May 21, 2021

Conversation

ManDude
Copy link
Member

@ManDude ManDude commented May 11, 2021

No description provided.

@water111
Copy link
Collaborator

I'm pretty sure this fails because I haven't done #443 yet.

The obj arguments to the res-tag methods and the (tag res-tag) argument to dummy-14 need to use 128-bit registers, but right now they use 64-bit registers, so it causes an error.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 862723641

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.088%
Totals Coverage Status
Change from base Build 862217502: 0.0%
Covered Lines: 34672
Relevant Lines: 50185
💛 - Coveralls

@water111 water111 merged commit 6ac399c into open-goal:master May 21, 2021
@ManDude ManDude deleted the d/start-decomp-res branch May 21, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManDude @water111 @coveralls