Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(local_visualizer.py): add check dir exist #1828

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

tpoisonooo
Copy link
Contributor

@tpoisonooo tpoisonooo commented Sep 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add output dir check, output_file is actually an directory.

open-mmlab/mmdeploy#1039 needs it.

Modification

add os.mkdir

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne
Copy link
Collaborator

Lint failed, can be merged after fix linting issue.

@tpoisonooo
Copy link
Contributor Author

Lint failed, can be merged after fix linting issue.

done.

@Tai-Wang Tai-Wang merged commit 677954b into open-mmlab:dev-1.x Sep 16, 2022
@Tai-Wang Tai-Wang added the 1.x label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants