Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format_only option for nuScenes and Waymo evaluation #2151

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 45.29% // Head: 45.29% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c09c009) compared to base (4e28378).
Patch coverage: 28.78% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2151      +/-   ##
===========================================
- Coverage    45.29%   45.29%   -0.01%     
===========================================
  Files          255      255              
  Lines        20822    20821       -1     
  Branches      3288     3292       +4     
===========================================
- Hits          9431     9430       -1     
  Misses       10771    10771              
  Partials       620      620              
Flag Coverage Δ
unittests 45.29% <28.78%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/metrics/nuscenes_metric.py 11.43% <20.00%> (-0.53%) ⬇️
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <31.25%> (-0.04%) ⬇️
mmdet3d/evaluation/metrics/kitti_metric.py 9.09% <40.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Tai-Wang
Tai-Wang previously approved these changes Dec 26, 2022
@Tai-Wang Tai-Wang dismissed their stale review December 26, 2022 05:34

Need to resolve minor comments

@Tai-Wang Tai-Wang changed the title Support to submit test set results on NuScenes and Waymo Dataset. Add format_only option for nuScenes and Waymo evaluation Dec 26, 2022
@Xiangxu-0103 Xiangxu-0103 requested a review from Tai-Wang January 11, 2023 02:58
@ZwwWayne ZwwWayne merged commit 8bf2f5a into open-mmlab:dev-1.x Jan 18, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the nuscenes_and_waymo_testset branch January 28, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants