Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Format semantickitti label mapping #2323

Merged
merged 17 commits into from
Mar 15, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Format semantickitti label mapping and fix some loading bug.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (cf6f473) 46.86% compared to head (793bebc) 46.88%.

❗ Current head 793bebc differs from pull request most recent head 364d758. Consider uploading reports for the commit 364d758 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2323      +/-   ##
===========================================
+ Coverage    46.86%   46.88%   +0.01%     
===========================================
  Files          264      264              
  Lines        22173    22175       +2     
  Branches      3482     3482              
===========================================
+ Hits         10392    10396       +4     
+ Misses       11118    11116       -2     
  Partials       663      663              
Flag Coverage Δ
unittests 46.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/__init__.py 100.00% <100.00%> (ø)
mmdet3d/datasets/seg3d_dataset.py 72.91% <100.00%> (+4.83%) ⬆️
mmdet3d/datasets/semantickitti_dataset.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -2,13 +2,11 @@
dataset_type = 'SemanticKITTIDataset'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this file to semantickitti-seg.py?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think semantickitti already indicates that is the semantic version of the kitti dataset.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we should repalce SemanticKITTIDataset with SemanticKittiDataset

configs/_base_/datasets/semantickitti.py Show resolved Hide resolved
@@ -2,13 +2,11 @@
dataset_type = 'SemanticKITTIDataset'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do that

@sunjiahao1999 sunjiahao1999 requested a review from ZwwWayne March 14, 2023 07:45
@ZwwWayne ZwwWayne merged commit e943e84 into open-mmlab:dev-1.x Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants