Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-259]Document Writing: Advanced Tutorial - Custom Data Augmentation #2605

Merged

Conversation

chaodyna
Copy link
Contributor

@chaodyna chaodyna commented Aug 8, 2023

Motivation

To add advanced tutorial: customize_transforms in zh_CN and en language.
添加了 [进阶教程:自定义数据变换和增强] 文档的简体中文和英文版本。

Modification

Added customize_transforms.md in the docs/advanced directory. The transforms.md file provides a preliminary analysis of data transformation and data augmentation.
补充了docs/advanced目录下的customize_transforms.md 文件,对数据变换和数据增强做了初步的分析

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2023

CLA assistant check
All committers have signed the CLA.

```Python
import random
import mmcv
from mmcv.transforms import BaseTransform, TRANSFORMS
Copy link
Collaborator

@Tau-J Tau-J Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this tutorial, please use MMPose's TRANSFORMS to give the example. Please avoid to use mmcv if it is not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment, It seems that I need to modification and correction. There are stil a lot to learn for me (

@Tau-J
Copy link
Collaborator

Tau-J commented Aug 9, 2023

Thanks for you contribution. As an advanced tutorial of MMPose, I think it is necessary to make sure all contents are related to MMPose (e.g. the code examples, the registry you use etc.) Please do not directly copy and paste the example from tutorial of MMEngine.

@Tau-J
Copy link
Collaborator

Tau-J commented Aug 18, 2023

Hi @chaodyna , since your pr branch lags behind our current dev-1.x. Please conduct following process to rebase your branch:

# switch to your forked dev-1.x
git checkout dev-1.x

# pull latest version of dev-1.x
git pull upstream dev-1.x

# switch back to your branch
git checkout chaodyna/advanced_customize_transforms_doc

# rebase dev-1.x
git rebase dev-1.x

# update your pr
git push origin chaodyna/advanced_customize_transforms_doc -f

If you meet any problem during this process, please feel free to contact us.

@chaodyna chaodyna changed the title CodeCamp2023-365 [CodeCamp2023-259]文档撰写:进阶教程-自定义数据增强 Aug 18, 2023
@chaodyna chaodyna force-pushed the chaodyna/advanced_customize_transforms_doc branch from 45e69bb to 1039c3c Compare August 18, 2023 08:13
@chaodyna
Copy link
Contributor Author

Thanks for your guidance! I just followed to pull my forked branch. If there is any need to improve or supplement, It's my expectation to help myself better.

@chaodyna chaodyna changed the title [CodeCamp2023-259]文档撰写:进阶教程-自定义数据增强 [CodeCamp2023-259]Document Writing: Advanced Tutorial - Custom Data Augmentation Aug 20, 2023
@Tau-J
Copy link
Collaborator

Tau-J commented Aug 20, 2023

Hello @chaodyna , the document after your recent modifications is much improved compared to before. I hope you could further expand on the section about the RandomFlip example. Please inform users that the key to custom data augmentation lies in writing the transform() function. Also, explain the input and output format and content of the 'transform()' function.

@chaodyna
Copy link
Contributor Author

chaodyna commented Aug 20, 2023 via email

@OpenMMLab-Assistant-004

Hi @chaodyna,

We'd like to express our appreciation for your valuable contributions to the mmpose. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@chaodyna chaodyna force-pushed the chaodyna/advanced_customize_transforms_doc branch 8 times, most recently from 360bc05 to 4989c68 Compare August 28, 2023 12:07
Comment on lines 26 to 50
```mermaid
flowchart LR
subgraph Transforms1
Flip
HalfBody
Rotation
Shift
Resize
ColorJittor
end
subgraph Transforms2
GenerateTarget
end
subgraph Transforms3
PackPoseInput
end
原始图片 --> Transforms1
原始标注 --> Transforms1
Transforms1 --> 输入图片
Transforms1 --> 输入坐标值
输入坐标值 --> Transforms2
Transforms2 --> Transforms3
输入图片 --> Transforms3

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chaodyna , would you please save this diagram as an image and upload it? Our doc is based on readthedocs and it seems that the diagram cannot be rendered.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the compiled docs here:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, The flowchart is already in the assets and was wrote so well🤣. I changed the linking image to mermaid.live, which is a useful tool and seems like steady to use. If there is any necessity to renovate and amend, I would like to learn from other friends and read the docs since it' been some time.

@chaodyna chaodyna force-pushed the chaodyna/advanced_customize_transforms_doc branch 2 times, most recently from a6faf2c to f2fe0e0 Compare August 30, 2023 14:12
@chaodyna chaodyna force-pushed the chaodyna/advanced_customize_transforms_doc branch from f2fe0e0 to e7c5178 Compare August 30, 2023 23:41
Copy link
Collaborator

@Tau-J Tau-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tau-J Tau-J merged commit 86f18d8 into open-mmlab:dev-1.x Aug 31, 2023
Tau-J added a commit that referenced this pull request Oct 12, 2023
* update

* [Fix] Fix HRFormer log link

* [Feature] Add Application 'Just dance' (#2528)

* [Docs] Add advanced tutorial of implement new model. (#2539)

* [Doc] Update img (#2541)

* [Feature] Support MotionBERT (#2482)

* [Fix] Fix demo scripts (#2542)

* [Fix] Fix Pose3dInferencer keypoint shape bug (#2543)

* [Enhance] Add notifications when saving visualization results (#2545)

* [Fix] MotionBERT training and flip-test (#2548)

* [Docs] Enhance docs (#2555)

* [Docs] Fix links in doc (#2557)

* [Docs] add details (#2558)

* [Refactor] 3d human pose demo (#2554)

* [Docs] Update MotionBERT docs (#2559)

* [Refactor] Update the arguments of 3d inferencer to align with the demo script (#2561)

* [Enhance] Combined dataset supports custom sampling ratio (#2562)

* [Docs] Add MultiSourceSampler docs (#2563)

* [Doc] Refine docs (#2564)

* [Feature][MMSIG] Add UniFormer Pose Estimation to Projects folder (#2501)

* [Fix] Check the compatibility of inferencer's input/output  (#2567)

* [Fix]Fix 3d visualization (#2565)

* [Feature] Add bear example in just dance (#2568)

* [Doc] Add example and openxlab link for just dance (#2571)

* [Fix] Configs' paths of VideoPose3d (#2572)

* [Docs] update docs (#2573)

* [Fix] Fix new config bug in train.py (#2575)

* [Fix] Configs' of MotionBERT (#2574)

* [Enhance] Normalization option in 3d human pose demo and inferencer (#2576)

* [Fix] Fix the incorrect labels for training vis_head with combined datasets (#2550)

* [Enhance] Enhance 3dpose demo and docs (#2578)

* [Docs] Enhance Codecs documents (#2580)

* [Feature] Add DWPose distilled WholeBody RTMPose models (#2581)

* [Docs] Add deployment docs (#2582)

* [Fix] Refine 3dpose (#2583)

* [Fix] Fix config typo in rtmpose-x (#2585)

* [Fix] Fix 3d inferencer (#2593)

* [Feature] Add a simple visualize api (#2596)

* [Feature][MMSIG] Support badcase analyze in test (#2584)

* [Fix] fix bug in flip_bbox with xyxy format (#2598)

* [Feature] Support ubody dataset (2d keypoints) (#2588)

* [Fix] Fix visualization bug in 3d pose (#2594)

* [Fix] Remove use-multi-frames option (#2601)

* [Enhance] Update demos (#2602)

* [Enhance] wholebody support  openpose style visualization (#2609)

* [Docs] Documentation regarding 3d pose (#2599)

* [CodeCamp2023-533] Migration Deepfashion topdown heatmap algorithms to 1.x (#2597)

* [Fix] fix badcase hook (#2616)

* [Fix] Update dataset mim downloading source to OpenXLab (#2614)

* [Docs] Update docs structure (#2617)

* [Docs] Refine Docs (#2619)

* [Fix] Fix numpy error (#2626)

* [Docs] Update error info and docs (#2624)

* [Fix] Fix inferencer argument name (#2627)

* [Fix] fix links for coco+aic hrnet (#2630)

* [Fix] fix a bug when visualize keypoint indices (#2631)

* [Docs] Update rtmpose docs (#2642)

* [Docs] update README.md (#2647)

* [Docs] Add onnx of RTMPose models (#2656)

* [Docs] Fix mmengine link (#2655)

* [Docs] Update QR code (#2653)

* [Feature] Add DWPose (#2643)

* [Refactor] Reorganize distillers (#2658)

* [CodeCamp2023-259]Document Writing: Advanced Tutorial - Custom Data Augmentation (#2605)

* [Docs] Fix installation docs(#2668)

* [Fix] Fix expired links in README (#2673)

* [Feature] Support multi-dataset evaluation (#2674)

* [Refactor] Specify labels to pack in codecs (#2659)

* [Refactor] update mapping tables (#2676)

* [Fix] fix link (#2677)

* [Enhance] Enable CocoMetric to get ann_file from MessageHub (#2678)

* [Fix] fix vitpose pretrained ckpts (#2687)

* [Refactor] Refactor YOLOX-Pose into mmpose core package (#2620)

* [Fix] Fix typo in COCOMetric(#2691)

* [Fix] Fix bug raised by changing bbox_center to input_center (#2693)

* [Feature] Surpport EDPose for inference(#2688)

* [Refactor] Internet for 3d hand pose estimation (#2632)

* [Fix] Change test batch_size of edpose to 1 (#2701)

* [Docs] Add OpenXLab Badge (#2698)

* [Doc] fix inferencer doc (#2702)

* [Docs] Refine dataset config tutorial (#2707)

* [Fix] modify yoloxpose test settings (#2706)

* [Fix] add compatibility for argument `return_datasample` (#2708)

* [Feature] Support ubody3d dataset (#2699)

* [Fix] Fix 3d inferencer (#2709)

* [Fix] Move ubody3d dataset to wholebody3d (#2712)

* [Refactor] Refactor config and dataset file structures (#2711)

* [Fix] give more clues when loading img failed (#2714)

* [Feature] Add demo script for 3d hand pose  (#2710)

* [Fix] Fix Internet demo (#2717)

* [codecamp: mmpose-315] 300W-LP data set support (#2716)

* [Fix] Fix the typo in YOLOX-Pose (#2719)

* [Feature] Add detectors trained on humanart (#2724)

* [Feature] Add RTMPose-Wholebody (#2721)

* [Doc] Fix github action badge in README (#2727)

* [Fix] Fix bug of dwpose (#2728)

* [Feature] Support hand3d inferencer (#2729)

* [Fix] Fix new config of RTMW (#2731)

* [Fix] Align visualization color of 3d demo (#2734)

* [Fix] Refine h36m data loading and add head_size to PackPoseInputs (#2735)

* [Refactor] Align test accuracy for AE (#2737)

* [Refactor] Separate evaluation mappings from KeypointConverter (#2738)

* [Fix] MotionbertLabel codec (#2739)

* [Fix] Fix mask shape (#2740)

* [Feature] Add training datasets of RTMW (#2743)

* [Doc] update RTMPose README (#2744)

* [Fix] skip warnings in demo (#2746)

* Bump 1.2 (#2748)

* add comments in dekr configs (#2751)

---------

Co-authored-by: Peng Lu <penglu2097@gmail.com>
Co-authored-by: Yifan Lareina WU <mhsj16lareina@gmail.com>
Co-authored-by: Xin Li <7219519+xin-li-67@users.noreply.github.com>
Co-authored-by: Indigo6 <40358785+Indigo6@users.noreply.github.com>
Co-authored-by: 谢昕辰 <xiexinch@outlook.com>
Co-authored-by: tpoisonooo <khj.application@aliyun.com>
Co-authored-by: zhengjie.xu <jerryxuzhengjie@gmail.com>
Co-authored-by: Mesopotamia <54797851+yzd-v@users.noreply.github.com>
Co-authored-by: chaodyna <li0331_1@163.com>
Co-authored-by: lwttttt <85999869+lwttttt@users.noreply.github.com>
Co-authored-by: Kanji Yomoda <Kanji.yy@gmail.com>
Co-authored-by: LiuYi-Up <73060646+LiuYi-Up@users.noreply.github.com>
Co-authored-by: ZhaoQiiii <102809799+ZhaoQiiii@users.noreply.github.com>
Co-authored-by: Yang-ChangHui <71805205+Yang-Changhui@users.noreply.github.com>
Co-authored-by: Xuan Ju <89566272+juxuan27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants