Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login page route #740

Merged
merged 3 commits into from
Aug 22, 2023
Merged

fix login page route #740

merged 3 commits into from
Aug 22, 2023

Conversation

koonpeng
Copy link
Collaborator

What's new

Fix some missing migrations when upgrading to react router v6.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Teo Koon Peng added 3 commits August 22, 2023 12:00
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #740 (b317fd2) into main (189227b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   54.65%   54.65%           
=======================================
  Files         263      263           
  Lines        6528     6528           
  Branches      862      862           
=======================================
  Hits         3568     3568           
  Misses       2820     2820           
  Partials      140      140           
Flag Coverage Δ
dashboard 18.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth merged commit dec13be into main Aug 22, 2023
3 checks passed
@aaronchongth aaronchongth deleted the kp/fix-login-page-route branch August 22, 2023 07:30
aaronchongth pushed a commit that referenced this pull request Aug 22, 2023
* fix login page route

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

* also fix default route

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

* fix redirect

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

---------

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
(cherry picked from commit dec13be)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
This was referenced Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants