Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/hammer #749

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Port/hammer #749

merged 7 commits into from
Aug 25, 2023

Conversation

aaronchongth
Copy link
Member

What's new

Ports

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

aaronchongth and others added 7 commits August 21, 2023 21:22
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* fix login page route

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

* also fix default route

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

* fix redirect

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>

---------

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
* Rename place to waypoint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reduce delivery form requirements to just pickup and dropoff waypoint names

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Adding WaypointCollection, which filters each waypoint type, display waypoint options only for that type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Disable menu item if task is unavailable

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix error of passing a value to element by int instead of string

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using patrol instead of loop

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix documentation and create-task story

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert to Place, as Waypoint implies routes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert changes to variable names

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor if case

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* Fixing missing handler delivery task description

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Disabled delivery when either pickup or dropoff points are empty

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* Add routes to delete only one job

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add except date to cancel a job

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Testing clear only one job

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove unused endpoint

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Delete all jobs and create again when except date is included this week

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Show event or not depending of the except date

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Fix comment to explain the code better

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add except date to the Schedule task and remove from ScheduleTaskschedule

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Create a endpoint to add a except date to the array and check whether or not the curretn date is include in the array of except_dates

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Adding control in order to show events

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Add confirmation popup to delete one event or all events

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Sort alphabetical order

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Remove console.log

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Using throw error to show message in console

Signed-off-by: angatupyry <fierrofenix@gmail.com>

* Change the endpoint and endpoint parameters to make them more accurate and understandable.

Signed-off-by: angatupyry <fierrofenix@gmail.com>

---------

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Aug 25, 2023
5 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #749 (de3a5ad) into deploy/hammer (d755f14) will decrease coverage by 0.40%.
Report is 3 commits behind head on deploy/hammer.
The diff coverage is 10.18%.

@@                Coverage Diff                @@
##           deploy/hammer     #749      +/-   ##
=================================================
- Coverage          54.65%   54.26%   -0.40%     
=================================================
  Files                263      263              
  Lines               6528     6583      +55     
  Branches             862      875      +13     
=================================================
+ Hits                3568     3572       +4     
- Misses              2820     2871      +51     
  Partials             140      140              
Flag Coverage Δ
api-server 82.28% <26.66%> (-0.30%) ⬇️
dashboard 18.01% <6.66%> (-0.44%) ⬇️
react-components 52.08% <9.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app-events.ts 100.00% <ø> (ø)
packages/dashboard/src/components/app.tsx 0.00% <ø> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% <0.00%> (ø)
...ackages/react-components/lib/tasks/create-task.tsx 2.38% <0.00%> (+0.03%) ⬆️
packages/dashboard/src/components/appbar.tsx 29.16% <18.18%> (-2.88%) ⬇️
packages/react-components/lib/place.ts 15.78% <18.75%> (+15.78%) ⬆️
...-server/api_server/routes/tasks/scheduled_tasks.py 78.57% <21.42%> (-11.43%) ⬇️
...pi_server/models/tortoise_models/scheduled_task.py 88.13% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth merged commit 1fb4560 into deploy/hammer Aug 25, 2023
6 checks passed
@aaronchongth aaronchongth deleted the port/hammer branch August 25, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants