Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the entire recurring event or only the selected event #742

Merged
merged 15 commits into from
Aug 25, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • New field added into ScheduleTask model. except_dates. An array that stores the dates that the user does not want a job to run.
  • Added an endpoint to regenerate the schedule based on exception days.
  • Added a pop-up with the option to delete all events or just the selected event.
chrome-capture-2023-7-22.webm
chrome-capture-2023-7-22.1.webm

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
…dule

Signed-off-by: angatupyry <fierrofenix@gmail.com>
… or not the curretn date is include in the array of except_dates

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #742 (11099e6) into main (5fcccd3) will decrease coverage by 0.39%.
Report is 6 commits behind head on main.
The diff coverage is 8.00%.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   54.64%   54.26%   -0.39%     
==========================================
  Files         263      263              
  Lines        6524     6581      +57     
  Branches      862      870       +8     
==========================================
+ Hits         3565     3571       +6     
- Misses       2819     2870      +51     
  Partials      140      140              
Flag Coverage Δ
api-server 82.28% <26.66%> (-0.31%) ⬇️
dashboard 18.06% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% <0.00%> (ø)
...-server/api_server/routes/tasks/scheduled_tasks.py 78.57% <21.42%> (-11.43%) ⬇️
...pi_server/models/tortoise_models/scheduled_task.py 88.13% <100.00%> (+0.20%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this epic feature! I'll test the feature over the weekend for multiple days to check that scheduling and deletion is working. For now, I've left some comments, let me know what you think!

packages/dashboard/src/components/tasks/tasks-app.tsx Outdated Show resolved Hide resolved
packages/dashboard/src/components/tasks/tasks-app.tsx Outdated Show resolved Hide resolved
packages/dashboard/src/components/tasks/tasks-app.tsx Outdated Show resolved Hide resolved
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
…e and understandable.

Signed-off-by: angatupyry <fierrofenix@gmail.com>
Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Thanks! LGTM

@aaronchongth aaronchongth merged commit b6daddc into main Aug 25, 2023
5 checks passed
@aaronchongth aaronchongth deleted the feature/scheduling-delete branch August 25, 2023 07:35
This was referenced Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants