Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making default zoom levels a single source of truth #747

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

aaronchongth
Copy link
Member

What's new

In order to make changing default zoom levels easier (before we migrate to react-three-fiber), I propose using a single source of truth for the default zoom level. This can make changing zoom levels for different deployments easier.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #747 (ee15972) into main (1412804) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   54.52%   54.51%   -0.01%     
==========================================
  Files         263      263              
  Lines        6548     6549       +1     
  Branches      865      866       +1     
==========================================
  Hits         3570     3570              
- Misses       2838     2839       +1     
  Partials      140      140              
Flag Coverage Δ
dashboard 18.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app-events.ts 100.00% <ø> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronchongth aaronchongth merged commit 54c4d3a into main Aug 24, 2023
3 checks passed
@aaronchongth aaronchongth deleted the fix/single-source-default-zoom branch August 24, 2023 15:45
This was referenced Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants