Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cart ID fields in double compose delivery form #967

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Remove cart ID fields in double compose delivery form #967

merged 3 commits into from
Jul 11, 2024

Conversation

aaronchongth
Copy link
Member

What's new

Removing cart ID field in double compose delivery task form

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Remove cart ID fields in double compose delivery form
1490593 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Lint
ee31881 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fix test
bbd1233 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit bf7e10b into deploy/hammer-humble Jul 11, 2024
3 checks passed
@aaronchongth aaronchongth deleted the hammer-humble/double-delivery-no-cart branch July 11, 2024 02:52
aaronchongth added a commit that referenced this pull request Aug 6, 2024
@aaronchongth
Remove cart ID fields in double compose delivery form (#967)
19c5c36 
* Remove cart ID fields in double compose delivery form

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit bf7e10b)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth mentioned this pull request Aug 6, 2024
Closed
5 tasks
aaronchongth added a commit that referenced this pull request Aug 6, 2024
@aaronchongth
Remove cart ID fields in double compose delivery form (#967)
259b38f 
* Remove cart ID fields in double compose delivery form

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit bf7e10b)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronchongth