Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/double compose delivery #990

Closed
wants to merge 2 commits into from
Closed

Conversation

aaronchongth
Copy link
Member

What's new

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* First iteration of double compose delivery task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and fix dispatck task insert emergency lots workaround

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix favorite task confirmation text field, add more tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert addition of double compose delivery to resource manager

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Small UI tweaks to form field widths

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix tests, grid containers for warn time

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 3649b5e)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* Remove cart ID fields in double compose delivery form

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit bf7e10b)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Copy link
Member Author

Closing after considerations that this should be in deployment forks instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant