Add icons for location tags #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
|
Cleaned it up a bit, I suspect some of the duplicated code to go through new tags and spawn meshes if necessary could be refactored into a separate function but since the duplicated functions differ a bit (one always spawns all tags on new location, one needs to check for differences on updated tags) it would be not too immediate / introduce a bit of overhead, but that can be done if needed. |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
|
With 557d68f, removed spawn robot and workcell tag visualization since these will be handled by the upcoming Scenarios |
mxgrey
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
Closes #101. Adds icons to the small rectangles around the locations to show their properties on first inspection. An example of the behavior is below:
Screencast.from.2023-06-27.10-28-28.webm
Implementation description
I adapted the available icons from traffic editor and sketched two new ones for workcells and robot spawning. They don't look great but I'm not sure how to do them better, happy to substitute them with anything.
The code is very verbose because of the tags being contained in a vector, I'll play around a bit and see if I can simplify it a bit (but that might require refactoring the
LocationTagscomponent).