Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request_type identifier and configurable retreat_to_charger #114

Closed
wants to merge 2 commits into from

Conversation

xiyuoh
Copy link
Member

@xiyuoh xiyuoh commented Mar 12, 2024

This PR

  • Adds retreat_to_charger to the task planner params, enabling it to be configured from the fleet config
  • Adds a virtual get function in RequestFactory and implement them to allow request factory identifiers to be retrievable. The identifiers we currently have are Charge and ParkRobot.

Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something but the "automatic retreat to the charger" behavior in the fleet adapters has nothing to do with the task planning in rmf_task. The issue should be resolved by creating/resetting this timer

@xiyuoh
Copy link
Member Author

xiyuoh commented Mar 12, 2024

@Yadunund You're right, the timer is where it happens. This PR primarily stores retreat_to_charger as a boolean in Constraints, along with the other battery-related constraints. A check is implemented in my other PR in the fleet adapter - if retreat_to_charger is disabled, then exit the timer callback. Should i be storing this param elsewhere?

@xiyuoh xiyuoh closed this Aug 2, 2024
@xiyuoh xiyuoh deleted the xiyu/disable_automatic_retreat branch August 2, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants