add world 'dae export ready' option, bugfixes for alpha values #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
|
@luca-della-vedova I'll defer to your Ignition knowledge here and understanding of how DAE export would be used 🙇 |
Comment on lines
+185
to
+188
| if dae_export_plugin is False: | ||
| for vertex_idx, vertex in enumerate(self.vertices): | ||
| if 'spawn_robot_type' in vertex.params: | ||
| self.generate_robot_at_vertex_idx(vertex_idx, world_ele) |
There was a problem hiding this comment.
I wonder if we should limit the filtered objects to only robots or to all the dynamic objects, i.e. lifts / doors.
What would you recommend?
There was a problem hiding this comment.
yup i forgot about that, we should remove those
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix/Fix applied
Alpha bugfixes
New feature implementation
Implemented feature
Add option "ignition_dae_export" to export world files ready for ignition to do dae exports.
Implementation description
This option enables our worlds to be 'dae export ready' via adding the correct plugin tags and removing any robots.
Related ignition PR: gazebosim/gz-sim#474
Downstream PR: open-rmf/rmf_demos#53