Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Recombine operator inverts 'overwrite_with' setting #30783

Closed
djaglowski opened this issue Jan 25, 2024 · 0 comments · Fixed by #30786
Closed

[pkg/stanza] Recombine operator inverts 'overwrite_with' setting #30783

djaglowski opened this issue Jan 25, 2024 · 0 comments · Fixed by #30786
Assignees
@djaglowski
Labels
bug Something isn't working

Comments

@djaglowski
Copy link
Member

Component(s)

pkg/stanza

What happened?

Description

When using the overwrite_with setting, the recombine operator should either choose the newest or oldest entry in a batch as the base. Currently, it is doing the opposite in each case.

While this is clearly a bug fix, it may make sense to invert the default value as well, so that people currently using the operator without this setting do not experience a breaking change.

Collector version

v0.92.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@djaglowski djaglowski added bug Something isn't working needs triage New item requiring triage labels Jan 25, 2024
@djaglowski djaglowski self-assigned this Jan 25, 2024
@djaglowski djaglowski removed the needs triage New item requiring triage label Jan 25, 2024
@djaglowski djaglowski mentioned this issue Jan 25, 2024
Merged
djaglowski added a commit that referenced this issue Jan 25, 2024
@djaglowski @songy23
[pkg/stanza] Fix recombine operator's 'overwrite_with' (#30786)
7a7ecce 
Fixes #30783

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@djaglowski djaglowski mentioned this issue Jan 25, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 30, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@djaglowski @songy23 @cparkins
[pkg/stanza] Fix recombine operator's 'overwrite_with' (open-telemetr…
cac7e11 
…y#30786)

Fixes open-telemetry#30783

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@github-actions github-actions bot mentioned this issue Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pkg/stanza] Fix recombine operator's 'overwrite_with' djaglowski/opentelemetry-collector-contrib
1 participant
@djaglowski