[pkg/stanza] Fix recombine operator's 'overwrite_with' #30786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Jan 25, 2024
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
djaglowski
added a commit
that referenced
this pull request
Jan 26, 2024
This updates the documentation according to changes in #30786
djaglowski
added a commit
that referenced
this pull request
Jan 26, 2024
This updates the documentation according to changes in #30786
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…y#30786) Fixes open-telemetry#30783 --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…metry#30796) This updates the documentation according to changes in open-telemetry#30786
yutingcaicyt
reviewed
Apr 3, 2024
Comment on lines
346
to
350
| if r.overwriteWithOldest { | ||
| base = entries[0] | ||
| } else { | ||
| base = entries[len(entries)-1] | ||
| } else { | ||
| base = entries[0] | ||
| } |
There was a problem hiding this comment.
@djaglowski Sorry, I don't quite understand this change. When overwrite_with = 'oldest', doesn't it mean that the attributes of the earliest entry are used? The change will use the latest entry as the base entry when overwrite_with = 'oldest'.
There was a problem hiding this comment.
You're right, I got it backwards. I've opened #32146 to correct it.
codeboten
pushed a commit
that referenced
this pull request
Apr 3, 2024
Effectively reverts #30786, due to error pointed out by @yutingcaicyt [here](#30786 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30783