Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests from cmd/otelcontribcol #30884

Closed
atoulme opened this issue Jan 30, 2024 · 4 comments · Fixed by #34844
Closed

Remove tests from cmd/otelcontribcol #30884

atoulme opened this issue Jan 30, 2024 · 4 comments · Fixed by #34844
Labels
ci-cd CI, CD, testing, build issues cmd/otelcontribcol otelcontribcol command never stale Issues marked with this label will be never staled and automatically removed

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 30, 2024

Component(s)

cmd/otelcontribcol

Describe the issue you're reporting

Those tests take a long time to compile and slow down execution of CI. They are replaced by generated tests.
@atoulme atoulme added the needs triage New item requiring triage label Jan 30, 2024
@atoulme atoulme mentioned this issue Jan 30, 2024
Closed
@crobert-1 crobert-1 added cmd/otelcontribcol otelcontribcol command ci-cd CI, CD, testing, build issues labels Jan 30, 2024
@atoulme atoulme mentioned this issue Jan 31, 2024
Closed
@TylerHelmuth TylerHelmuth mentioned this issue Jan 31, 2024
Merged
@crobert-1
Copy link
Member

The problem was generally discussed in the Collector sig meeting today, it sounds like suggestions are welcome to alleviate this. Removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 31, 2024
@github-actions github-actions bot mentioned this issue Feb 6, 2024
Closed
@andrzej-stencel andrzej-stencel mentioned this issue Mar 11, 2024
Closed
@crobert-1 crobert-1 mentioned this issue Mar 13, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 1, 2024
@crobert-1 crobert-1 removed the Stale label Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jun 3, 2024
@crobert-1 crobert-1 added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jun 3, 2024
@mowies
Copy link
Member

mowies commented Sep 17, 2024

if this is still relevant, it will be fixed in #34844

@mowies mowies mentioned this issue Sep 17, 2024
Merged
andrzej-stencel pushed a commit that referenced this issue Oct 3, 2024
@mowies
[chore] remove generated code (#34844)
30fc917 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
#27850
Fixes #30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mowies @jriguera
[chore] remove generated code (open-telemetry#34844)
4ae841e 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@mowies @AkhigbeEromo
[chore] remove generated code (open-telemetry#34844)
d895eae 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR:
- removes all of the auto generated files in cmd/otelcontribcol and
cmd/oteltestbedcol
- left some files in place to support the setup, e.g. Dockerfile,
metadata.yaml files, builder-config.yaml files
- adds gitignore files in the folders in question to prevent committing
of auto-generated files
- adds the tools folder to all actions/cache pipeline steps since there
were some caching issues that came up during development of this PR
- adds make generate commands to place where the auto-generated code
files are needed

**Link to tracking Issue:**
Fixes
open-telemetry#27850
Fixes open-telemetry#30884

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues cmd/otelcontribcol otelcontribcol command never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @mowies @crobert-1