Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Delete otelcontribcol code #30902

Closed

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 31, 2024

Description:
Deletes the code under cmd/otelcontribcol, move to build it under cmd/otelcontribcol/_build without checking it in.

Link to tracking Issue:
Fixes #30884

@atoulme atoulme requested review from a team and jpkrohling January 31, 2024 02:31
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jan 31, 2024
@atoulme atoulme force-pushed the delete_otelcontribcol_code branch 4 times, most recently from e4a16d4 to 4b2b3cd Compare January 31, 2024 05:23
@atoulme atoulme requested a review from dmitryax as a code owner January 31, 2024 05:23
@atoulme atoulme force-pushed the delete_otelcontribcol_code branch from 4b2b3cd to 5709d52 Compare January 31, 2024 05:47
@dmitryax
Copy link
Member

Did we move all the lifecycle tests to the components?

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024

Did we move all the lifecycle tests to the components?

No, we still miss some, here is the list:

$> find . -mindepth 2 -maxdepth 2 -type d '!' -exec test -e "{}/generated_component_test.go" ';' -print | grep -E "(exporter|receiver|extension|connector|processor)"
./extension/asapauthextension
./extension/solarwindsapmsettingsextension
./extension/httpforwarder
./extension/awsproxy
./extension/encoding
./extension/storage
./extension/basicauthextension
./extension/jaegerremotesampling
./processor/deltatocumulativeprocessor
./receiver/windowseventlogreceiver
./receiver/windowsperfcountersreceiver
./receiver/elasticsearchreceiver
./receiver/awsxrayreceiver
./receiver/namedpipereceiver
./receiver/sqlserverreceiver
./receiver/filelogreceiver
./receiver/filereceiver
./receiver/journaldreceiver
./receiver/kubeletstatsreceiver
./receiver/awsecscontainermetricsreceiver
./receiver/datadogreceiver
./receiver/k8sobjectsreceiver
./receiver/osqueryreceiver
./receiver/jmxreceiver
./receiver/mongodbatlasreceiver
./receiver/activedirectorydsreceiver
./receiver/chronyreceiver
./receiver/dockerstatsreceiver
./receiver/receivercreator
./receiver/gitproviderreceiver
./receiver/iisreceiver
./receiver/k8sclusterreceiver
./connector/failoverconnector
./connector/routingconnector
./connector/datadogconnector
./exporter/loadbalancingexporter
./exporter/fileexporter
./exporter/pulsarexporter
./exporter/awskinesisexporter
./exporter/influxdbexporter
./exporter/instanaexporter
./exporter/elasticsearchexporter
./exporter/googlemanagedprometheusexporter
./exporter/awsemfexporter
./exporter/kafkaexporter
./exporter/skywalkingexporter
./exporter/coralogixexporter
./exporter/googlecloudpubsubexporter
./exporter/prometheusexporter
./exporter/f5cloudexporter
./exporter/prometheusremotewriteexporter
./exporter/lokiexporter
./exporter/zipkinexporter
./exporter/carbonexporter
./exporter/tencentcloudlogserviceexporter
./exporter/sumologicexporter
./exporter/syslogexporter
./exporter/azuredataexplorerexporter
./exporter/googlecloudexporter
./exporter/mezmoexporter
./exporter/otelarrowexporter
./exporter/cassandraexporter
./exporter/logicmonitorexporter
./exporter/opencensusexporter

FWIW I updated #27849 to reflect this list.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be blocked on the lifecycle changes?

@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024

Yes and no ; it can be debated in a SIG meeting. Right now the current tests bail when the creation of the component fails, and the new tests are less forgiving. So our test coverage is actually probably already better with the new generated tests. That said, we don't have them done everywhere.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 15, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 1, 2024
@atoulme atoulme reopened this Mar 1, 2024
@github-actions github-actions bot removed the Stale label Mar 2, 2024
@atoulme atoulme force-pushed the delete_otelcontribcol_code branch 2 times, most recently from b60e26f to fcbf26c Compare March 15, 2024 04:57
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 29, 2024
@atoulme atoulme removed the Stale label Apr 5, 2024
@atoulme atoulme force-pushed the delete_otelcontribcol_code branch from fcbf26c to 837b721 Compare April 5, 2024 05:59
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 20, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tests from cmd/otelcontribcol
4 participants