Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/postgresql] Generated "name" is inconsistent with other scrapers (nit) #6828

Closed
djaglowski opened this issue Dec 16, 2021 · 1 comment
Closed

[receiver/postgresql] Generated "name" is inconsistent with other scrapers (nit) #6828

djaglowski opened this issue Dec 16, 2021 · 1 comment
Assignees
@djaglowski
Labels
bug Something isn't working

Comments

@djaglowski
Copy link
Member

Scraper metadata.yaml files contain a name key which is used to generate a few values in various scraper files. The postgresql receiver is the only one that omits the receiver suffix. This should be added in order to maintain consistency across scrapers.
@djaglowski djaglowski added the bug Something isn't working label Dec 16, 2021
@djaglowski djaglowski mentioned this issue Dec 16, 2021
Merged
@djaglowski djaglowski self-assigned this Dec 16, 2021
@djaglowski djaglowski changed the title [receiver/postgresql] - Generated "name" is inconsistent with other scrapers (nit) [receiver/postgresql] Generated "name" is inconsistent with other scrapers (nit) Dec 17, 2021
@djaglowski
Copy link
Member Author

Resolved by #6829

animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
@mx-psi
[chore] changelog + prepare release v1.0.0-rc2 (open-telemetry#6828)
3efa2bc 
Re-do of open-telemetry#6820

- make chlog-update and update of core builder test
- Amend changelog name
- prepare release v1.0.0-rc2
- Prepare stable for version v1.0.0-rc2
- add multimod changes

This corresponds to the first three points under step 6. The last point is done on a separate PR, open-telemetry/opentelemetry-collector#6822.

Link to tracking Issue: Fixes open-telemetry/opentelemetry-collector#6819

Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djaglowski