[extension/observer/k8s] Add k8s.node discovery #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
3 times, most recently
from
e450bef
to
10af79f
Compare
jpkrohling
changed the title
jpkrohling
changed the title
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
from
10af79f
to
77b7ad0
Compare
dmitryax
reviewed
Dec 17, 2021
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
3 times, most recently
from
a52f637
to
c989cae
Compare
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
from
c989cae
to
64c740c
Compare
|
@rmfitzpatrick @dmitryax can you also add yourself as codeowners for this extension? Can be in a separate PR. |
|
@rmfitzpatrick the lint job is failing. |
|
@rmfitzpatrick please rebase, the linter job is fixed now |
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
from
64c740c
to
41cdea7
Compare
added 4 commits
December 21, 2021 16:04
These changes adopt the new k8s.node endpoint type in the k8s_observer and provide new config fields `observe_nodes` and `observe_pods` to toggle desired Endpoint type discovery. The existing `node` config field is no longer mandatory and missing values will result in all available nodes and pods in being reported. They do not include adoption in the receiver creator, as that will be addressed in a subsequent PR.
rmfitzpatrick
force-pushed
the
k8sobservernodediscovery
branch
from
43115a1
to
62e1bb7
Compare
mstumpfx
approved these changes
Dec 21, 2021
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
Re-do of open-telemetry#6820 - make chlog-update and update of core builder test - Amend changelog name - prepare release v1.0.0-rc2 - Prepare stable for version v1.0.0-rc2 - add multimod changes This corresponds to the first three points under step 6. The last point is done on a separate PR, open-telemetry/opentelemetry-collector#6822. Link to tracking Issue: Fixes open-telemetry/opentelemetry-collector#6819 Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding a feature -
These changes adopt the new
k8s.nodeendpoint type in the k8s_observer and provide new config fieldsobserve_nodesandobserve_podsto toggle desired Endpoint type discovery. The existingnodeconfig field is no longer mandatory and missing values will result in all available nodes and pods in being reported.They do not include adoption in the receiver creator, as that will be addressed in a subsequent PR.
Link to tracking Issue:
#6540
Testing:
Added unit tests for endpoint conversion and
observer.Observablemethods.Documentation:
Updated readme with usage and config improvements, though they are dependent on separate receiver creator adoption.