Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry loop for flaky tests #10823

Closed
wants to merge 1 commit into from
Closed

Add retry loop for flaky tests #10823

wants to merge 1 commit into from

Conversation

kevinearls
Copy link
Member

Signed-off-by: Kevin Earls kearls@redhat.com

Description:
This adds a retry loop to fix flaky tests.

Link to tracking Issue:
#10368 , #10369 , #10370

Signed-off-by: Kevin Earls <kearls@redhat.com>
@kevinearls kevinearls requested a review from a team June 7, 2022 14:38
@kevinearls kevinearls requested a review from jpkrohling as a code owner June 7, 2022 14:38
@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 8, 2022
@TylerHelmuth
Copy link
Member

@kevinearls do you know why these tests are failing to properly find open ports? Is there a bug somewhere in testutil.GetAvailablePort(t) that is the root cause that can be fixed?

@kevinearls
Copy link
Member Author

@TylerHelmuth No, I don't really. I tried taking that approach but couldn't figure it out. Unfortunately I don't really have much more time to spend on this right now.

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Jun 9, 2022

@kevinearls can you look into if getExclusionsList (which is used within GetAvailablePort) is not properly excluding all windows reserved ports. It is likely that there are some ports sneaking through the exclusion and they sometimes get chosen when they shouldn't. Try replacing "protocol=tcp" with "protocol=udp" or maybe adding "protocol=udp".

@bogdandrutu
Copy link
Member

@kevinearls @TylerHelmuth I have a fix for the root problem, see #10872

@bogdandrutu bogdandrutu closed this Jun 9, 2022
@bogdandrutu
Copy link
Member

@kevinearls thanks for your contribution, we merged the other PR that fixed the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants