Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/testutil: Exclude port ranges for both TCP and UDP #10872

Merged
merged 1 commit into from
Jun 9, 2022
Merged

common/testutil: Exclude port ranges for both TCP and UDP #10872

merged 1 commit into from
Jun 9, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jun 9, 2022 •
edited
Loading

Fixes #10370
Fixes #10369
Fixes #10368
Fixes #10151
Fixes #1391

I printed the output of the commands on github actions:

=== RUN   TestTCPAndUDP
    testutil_test.go:87: TCP Command
    testutil_test.go:88: 
        Protocol tcp Port Exclusion Ranges
        Start Port    End Port      
        ----------    --------      
                80          80      
              5986        5986      
             47001       47001      
             51417       51516      
             51517       51616      
        * - Administered port exclusions.
    testutil_test.go:95: UDP Command
    testutil_test.go:96: 
        Protocol udp Port Exclusion Ranges
        Start Port    End Port      
        ----------    --------      
             56030       56129      
             56130       56229      
        * - Administered port exclusions.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and djaglowski June 9, 2022 18:15
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 9, 2022
@bogdandrutu bogdandrutu force-pushed the testtcpudp branch 2 times, most recently from 5bf8666 to 30b9d74 Compare June 9, 2022 19:07
@bogdandrutu bogdandrutu changed the title Add test for TCP and UDP excludedportrange common/testutil: Exclude port ranges for both TCP and UDP Jun 9, 2022
@bogdandrutu bogdandrutu mentioned this pull request Jun 9, 2022
Closed
@bogdandrutu
common/testutil: Exclude port ranges for both TCP and UDP
b2514d0 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 00a960b into open-telemetry:main Jun 9, 2022
@bogdandrutu bogdandrutu deleted the testtcpudp branch June 9, 2022 20:10
@djaglowski djaglowski mentioned this pull request Jun 13, 2022
Closed
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
@bogdandrutu @kentquirk
common/testutil: Exclude port ranges for both TCP and UDP (open-telem…
6db93e9 
…etry#10872)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

@pmm-sumo pmm-sumo

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
3 participants
@bogdandrutu @TylerHelmuth @pmm-sumo