[pkg/telemetryquerylanguage] Move contexts to package #12589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @kentquirk |
kentquirk
reviewed
Jul 21, 2022
Co-authored-by: Kent Quirk <kentquirk@gmail.com>
|
@open-telemetry/collector-contrib-approvers please review |
|
@dashpole are you free to review? There are a lot of changes, but they are copy and paste from the transform processor. See @kentquirk's comments for anything that was modified. |
|
With the merging of #12597 the contexts being added in this PR will need updated with the StandardGetSetter, but to avoid logic changes in this PR I will submit a different PR to do that update once this is merged. |
dashpole
approved these changes
Jul 27, 2022
TylerHelmuth
added
the
ready to merge
codeboten
approved these changes
Jul 27, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR copies the contexts from the transform processor into packages in the telemetryquerylanguage module.
Link to tracking Issue:
#11751
Testing:
Ran unit tests
Documentation:
Added new READMEs