[pkg/telemetryquerylanguage] Create reusable StandardGetSetter #12597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
|
/cc @kentquirk |
|
@open-telemetry/collector-contrib-approvers please review |
|
@dmitryax are you free to review? There are a lot of changes, but they should be mostly "renames". |
dmitryax
approved these changes
Jul 26, 2022
This was referenced Jul 26, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In order to facilitate moving functions to their own packages as part of #11751, we need a place to put testGetSetter so it could be reusable. That need cascaded into creating a basic GetSetter that ends up being useful everywhere. Instead of creating a new testLiteral, the existing Literal struct was exposed.
Link to tracking Issue:
#11751
Testing:
Ran unit tests