Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests using test containers are currently skipped #24240

Closed
bryan-aguilar opened this issue Jul 12, 2023 · 12 comments
Closed

Integration tests using test containers are currently skipped #24240

bryan-aguilar opened this issue Jul 12, 2023 · 12 comments
Assignees
@bryan-aguilar
Labels
extension/observer/dockerobserver receiver/dockerstats receiver/snmp receiver/sqlquery SQL query receiver release:blocker The issue must be resolved before cutting the next release

Comments

@bryan-aguilar
Copy link
Contributor

Component(s)

extension/observer/dockerobserver, receiver/dockerstats, receiver/snmp, receiver/sqlquery

Describe the issue you're reporting

See #24213 and testcontainers/testcontainers-go#1359
@bryan-aguilar bryan-aguilar added the needs triage New item requiring triage label Jul 12, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

Additionally, the scraperinttest package is used in many scrapers.

The full list of Skip commands can be seen here.

@TylerHelmuth
Copy link
Member

List of components that depend on scraperinttest

image

@TylerHelmuth
Copy link
Member

I believe that means at least 23 components are impacted by this issue

@bryan-aguilar bryan-aguilar mentioned this issue Jul 12, 2023
Merged
@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Jul 13, 2023
@mx-psi
Copy link
Member

mx-psi commented Jul 13, 2023

Labeled this as release:blocker since there seems to be agreement among maintainer/approvers that we should hold off from releasing until this is solved to ensure proper testing of all components.

@mx-psi mx-psi pinned this issue Jul 18, 2023
@jpkrohling
Copy link
Member

@bryan-aguilar, should this be assigned to you? I believe you are tracking this, having it assigned to you would make it more explicit.

@djaglowski
Copy link
Member

@mdelapenya, is there any way you could help us out here? We've had to temporarily disable all use of testcontainers and are blocking our release until testcontainers/testcontainers-go#1361 is resolved.

@mdelapenya
Copy link
Contributor

Hey @djaglowski I'm on parental leave until August 1st. I'll prioritize those open PRs to unblock you 🙏

@djaglowski
Copy link
Member

Enjoy your time @mdelapenya! Thanks for the response

@bryan-aguilar
Copy link
Contributor Author

@jpkrohling yes feel free to assign this to me. I have been actively monitoring the issue throughout the day and will update my draft PR as soon as a new release is available.

Maintainers, feel free to push to my PR #24247 if I happen to be AFK when a fix becomes available.

dmitryax pushed a commit that referenced this issue Jul 21, 2023
@bryan-aguilar
[chore] Reenable tests and linting disabled due to testconainters-go …
64e6a5e 
…issue (#24247)

**Description:** Dependent on
testcontainers/testcontainers-go#1359 being
resolved.

Enable tests that were skipped in #24213

**Link to tracking Issue:**
#24240
@mx-psi mx-psi removed the needs triage New item requiring triage label Jul 24, 2023
@mx-psi
Copy link
Member

mx-psi commented Jul 24, 2023

Can we close this given #24247 was merged, @bryan-aguilar?

@bryan-aguilar
Copy link
Contributor Author

Fixed in #24247

@atoulme atoulme unpinned this issue Jul 24, 2023
@djaglowski djaglowski mentioned this issue Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryan-aguilar bryan-aguilar

Labels
extension/observer/dockerobserver receiver/dockerstats receiver/snmp receiver/sqlquery SQL query receiver release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpkrohling @mdelapenya @djaglowski @mx-psi @TylerHelmuth @bryan-aguilar