prometheusreceiver: remove unused buffer_period and buffer_count configuration options #24257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration options
dashpole
force-pushed
the
remove_unused_config
branch
from
74e843c to
714b747
Compare
crobert-1
approved these changes
Jul 14, 2023
dmitryax
approved these changes
Jul 18, 2023
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #24258
Found while adding documentation for #24256. The prometheus receiver had two config options that AFAICT have never been used.
The config options have existed since the very first commit ever for the Prometheus receiver: 7c728ef
Testing:
Updated unit tests