Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheusreceiver: remove unused buffer_period and buffer_count configuration options #24257

Merged
merged 2 commits into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .chloggen/prometheus-config-cleanup.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Use this changelog template to create an entry for release notes.
# If your change doesn't affect end users, such as a test fix or a tooling change,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: 'breaking'

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: prometheusreciever

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove unused buffer_period and buffer_count configuration options

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [24258]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
2 changes: 0 additions & 2 deletions receiver/prometheusreceiver/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ const (
// Config defines configuration for Prometheus receiver.
type Config struct {
PrometheusConfig *promconfig.Config `mapstructure:"-"`
BufferPeriod time.Duration `mapstructure:"buffer_period"`
BufferCount int `mapstructure:"buffer_count"`
// UseStartTimeMetric enables retrieving the start time of all counter metrics
// from the process_start_time_seconds metric. This is only correct if all counters on that endpoint
// started after the process start time, and the process is the only actor exporting the metric after
Expand Down
2 changes: 0 additions & 2 deletions receiver/prometheusreceiver/testdata/config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
prometheus:
prometheus/customname:
buffer_period: 234
buffer_count: 45
use_start_time_metric: true
start_time_metric_regex: '^(.+_)*process_start_time_seconds$'
target_allocator:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
prometheus:
buffer_period: 234
buffer_count: 45
use_start_time_metric: true
start_time_metric_regex: '^(.+_)*process_start_time_seconds$'
config:
Expand Down