Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.22 for official builds #471

Closed
mx-psi opened this issue Feb 7, 2024 · 5 comments · Fixed by #600
Closed

Switch to Go 1.22 for official builds #471

mx-psi opened this issue Feb 7, 2024 · 5 comments · Fixed by #600
Assignees
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p1 High

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 7, 2024

Same as #383, but for Go 1.22.

Go 1.22 was released recently: go.dev/doc/go1.22

After we add testing for it on core (open-telemetry/opentelemetry-collector/issues/9507) and contrib (open-telemetry/opentelemetry-collector-contrib/issues/31105) we can switch to using the Go 1.22 compiler for official builds. Based on historical precedent this will make our life easier when dealing with security issues since we don't depend on the Go team backporting fixes and can react more quickly.

@mx-psi mx-psi added good first issue Good for newcomers go Pull requests that update Go code priority:p1 High labels Feb 7, 2024
@Enzujp
Copy link
Contributor

Enzujp commented Mar 22, 2024

Hello @mx-psi, @greut if this is still unattended and there are no blockers, I'd like to fix it.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 16, 2024
@mowies
Copy link
Member

mowies commented Jul 17, 2024

I double checked, all workflows are already on Go 1.22, the only place that's still on 1.21 is the go.mod file (repo search link). I can quickly file a PR to update that.

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jul 17, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jul 17, 2024

@mowies That does not affect official builds but we can do it anyways and close this issue with that PR :)

@mowies
Copy link
Member

mowies commented Jul 17, 2024

Seems like updating the version and running go mod tidy gets rid of most dependencies in there which doesn't seem right. Maybe a PR is not the best idea 😅

@mowies
Copy link
Member

mowies commented Jul 17, 2024

I opened the PR in draft mode for now if you wanna check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Good for newcomers priority:p1 High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants