Bump to Go 1.23 for all builds #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackgopack4 the build tests are failing, and I think it is related to #608. Could you take a look? |
|
just tested in my own repo and was able to get the proper tag detection working by adding a "monorepo" tag to each individual goreleaser file See the checks ran and succeeded with my own repo PR: jackgopack4#13 |
Merged
|
for some reason when I try to add the monorepo tag to the contrib and core goreleaser, the "make generate-goreleaser" wants to remove them. Looks like its not failing on the k8s distro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have open-telemetry/opentelemetry-collector-contrib/pull/34658 and open-telemetry/opentelemetry-collector/pull/10869 we can do the same as in #471