Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.22 #600

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update go to 1.22 #600

merged 1 commit into from
Jul 17, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Jul 17, 2024 •
edited
Loading

Fixes #471

@mowies
update go to 1.22
a77592d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mx-psi
mx-psi reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #572 removed github.com/goreleaser/nfpm/v2 but did not tidy the go.mod file.

@mowies
Copy link
Member Author

mowies commented Jul 17, 2024

Seem like it should be fine. Marking as ready for review :)

@mowies mowies marked this pull request as ready for review July 17, 2024 11:02
@mowies mowies requested review from a team and TylerHelmuth July 17, 2024 11:02
mx-psi
mx-psi approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you file an issue about ensuring go.mod is tidy on CI?

@mx-psi mx-psi merged commit 19d291d into open-telemetry:main Jul 17, 2024
31 checks passed
@mowies mowies deleted the update-go-mod-1-22 branch July 17, 2024 12:12
@mowies mowies mentioned this pull request Jul 17, 2024
Open
@mowies
Copy link
Member Author

mowies commented Jul 17, 2024

I filed a new issue now: #601

jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector-releases that referenced this pull request Jul 19, 2024
@mowies @jackgopack4
Update go to 1.22 (open-telemetry#600)
fd0be92 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies mentioned this pull request Aug 27, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Go 1.22 for official builds
2 participants
@mowies @mx-psi