Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ballast-size of collector seems incorrect in the example k8s file #1019

Closed
bohrasd opened this issue May 26, 2020 · 4 comments
Closed

The ballast-size of collector seems incorrect in the example k8s file #1019

bohrasd opened this issue May 26, 2020 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone

Comments

@bohrasd
Copy link

bohrasd commented May 26, 2020

Describe the bug
According to the memory limiter, the same value configured on the command line option mem-ballast-size-mib must also be defined in the memory_limiter processor. But they are not the same in the example k8s file.
L118
L196

What did you expect to see?
The same value configured on the command line option mem-ballast-size-mib must also be defined in the memory_limiter processor.

What did you see instead?
They are not the same.

What version did you use?
Version: daf2fc7

@bohrasd bohrasd added the bug Something isn't working label May 26, 2020
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label May 27, 2020
@flands flands self-assigned this Jun 18, 2020
flands added a commit to flands/opentelemetry-collector that referenced this issue Jun 18, 2020
Addresses open-telemetry#1019

Also add debug logging to local config YAML
@flands flands mentioned this issue Jun 18, 2020
@flands flands added this to the Beta 0.5 milestone Jun 18, 2020
@owais
Copy link
Contributor

owais commented Jun 18, 2020

According to the memory limiter, the same value configured on the command line option mem-ballast-size-mib must also be defined in the memory_limiter

This is not true. @bohrasd can you please point us to the docs that say this so we can fix the docs?

Ignore what I said, I misread your comment.

@flands
Copy link
Contributor

flands commented Jun 18, 2020

@owais I believe it is -- see the PR

@owais
Copy link
Contributor

owais commented Jun 18, 2020

Yes, I misread it as ballast size and memory limiter size being the same.

@owais
Copy link
Contributor

owais commented Jun 18, 2020

@flands I think we should remove everything related to ballast from the default configuration and mention it in the docs as an "advanced technique" for very high throughput scenarios. Majority of the deployment do not need it IMO and would benefit from a simpler setup.

bogdandrutu pushed a commit that referenced this issue Jun 20, 2020
* Fix k8s config

Addresses #1019

Also add debug logging to local config YAML

* Address feedback
@flands flands closed this as completed Jun 23, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
* Fix k8s config

Addresses open-telemetry#1019

Also add debug logging to local config YAML

* Address feedback
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
* Allow for secure deployments by default.

* Restored data added during testing to original state.

* Updated demo chart README.md.

* Added additional comments to values.yaml to illustrate how the new feature can be used.

* Executed "make generate-examples" and pushing results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

4 participants