Fix k8s config #1146
Merged
Fix k8s config #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses open-telemetry#1019 Also add debug logging to local config YAML
flands
requested review from
bogdandrutu,
dmitryax,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
dmitryax
reviewed
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
- Coverage 86.76% 86.73% -0.03%
==========================================
Files 201 201
Lines 14496 14496
==========================================
- Hits 12577 12573 -4
- Misses 1467 1470 +3
- Partials 452 453 +1
Continue to review full report at Codecov.
|
|
While this is a good hot fix, I think we should fix this is code so memory limiter automatically picks up whatever size is configured for memory ballast. |
|
Also, we should see if we move ballast to config instead of being a CLI arg. |
|
or this: #1078. These are separate issues though -- goal of this PR is to fix what we have today and is incorrect. |
owais
approved these changes
Jun 18, 2020
dmitryax
approved these changes
Jun 18, 2020
bogdandrutu
approved these changes
Jun 20, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Fix k8s config Addresses open-telemetry#1019 Also add debug logging to local config YAML * Address feedback
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…pen-telemetry#1146) * Bump google.golang.org/grpc from 1.31.1 to 1.32.0 in /exporters/otlp Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.31.1 to 1.32.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.31.1...v1.32.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
…try#1146) * fix references to old variables * add a note to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1019
Also add debug logging to local config YAML