Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Fix enabled config option for batch sender #10076

Merged
merged 1 commit into from
May 3, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented May 3, 2024

enabled config option for batch sender was ignored. This PR fixes it.

@dmitryax dmitryax requested review from a team and jpkrohling May 3, 2024 04:35
`enabled` config option for batch sender was ignored. This PR fixes it.
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (174f003) to head (ee99306).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10076   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         360      360           
  Lines       16725    16727    +2     
=======================================
+ Hits        15366    15368    +2     
  Misses       1021     1021           
  Partials      338      338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax merged commit 109173d into open-telemetry:main May 3, 2024
48 checks passed
@github-actions github-actions bot added this to the next release milestone May 3, 2024
@dmitryax dmitryax deleted the enabled-batch-sender branch May 3, 2024 16:47
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
…elemetry#10076)

`enabled` config option for batch sender was ignored. This PR fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants