add batcher config to splunkhec exporter #32563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @splunkericl, hope you don't mind, I updated your PR description to automatically close the issue. 👍 |
crobert-1
reviewed
Apr 19, 2024
splunkericl
force-pushed
the
hec-exporter-batching
branch
from
6a6ba86 to
34583d9
Compare
crobert-1
reviewed
Apr 24, 2024
crobert-1
reviewed
Apr 24, 2024
crobert-1
reviewed
Apr 24, 2024
splunkericl
force-pushed
the
hec-exporter-batching
branch
from
a26f33b to
be77cd0
Compare
|
@dmitryax @crobert-1 Thoughts on the latest documentations? |
crobert-1
approved these changes
Apr 30, 2024
dmitryax
reviewed
May 3, 2024
atoulme
approved these changes
May 3, 2024
|
waiting for open-telemetry/opentelemetry-collector#10076 to merge in so the exporter doesn't need the enabled if statement check |
|
@splunkericl the PR in core is merged and pulled to this repo. Please rebase and remove the condition |
splunkericl
force-pushed
the
hec-exporter-batching
branch
from
8e16cf7 to
a117868
Compare
|
Thanks @dmitryax . i have rebased and remove the if-statement. |
dmitryax
reviewed
May 3, 2024
dmitryax
approved these changes
May 4, 2024
dmitryax
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Aug 17, 2024
#### Description This PR adds opt-in support to oltp exporter for the experimental batch sender (#8122). By default batch sender is not enabled. Similar: * open-telemetry/opentelemetry-collector-contrib#34238 * open-telemetry/opentelemetry-collector-contrib#32563 #### Link to tracking issue Resolves #10834 #### Testing `exporter/otlpexporter/config_test.go` #### Documentation Updated the `oltpexporter` README to point to `exporterhelper` README for batching. --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new feature in splunk hec exporter
Link to tracking Issue:
Resolves #32545
Testing:
Added unit test for the config
Documentation:
Updated the README file