-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable batch sender in oltpexporter #10846
Conversation
/easycla |
1 similar comment
/easycla |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10846 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 404 404
Lines 18983 18990 +7
=======================================
+ Hits 17388 17395 +7
Misses 1235 1235
Partials 360 360 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just few nits
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
The failing contrib jobs will be fixed once open-telemetry/opentelemetry-collector-contrib#34721 is merged |
**Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter. Follows open-telemetry/opentelemetry-collector#10846 as we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters. **Link to tracking Issue:** **Testing:** ✅ **Documentation:** README updated with reference to new batcher and [concurrent batch processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor) in the otel-arrow repo. --------- Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
…try#34802) **Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter. Follows open-telemetry/opentelemetry-collector#10846 as we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters. **Link to tracking Issue:** **Testing:** ✅ **Documentation:** README updated with reference to new batcher and [concurrent batch processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor) in the otel-arrow repo. --------- Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Description
This PR adds opt-in support to oltp exporter for the experimental batch sender (#8122). By default batch sender is not enabled.
Similar:
batcher
config opentelemetry-collector-contrib#34238Link to tracking issue
Resolves #10834
Testing
exporter/otlpexporter/config_test.go
Documentation
Updated the
oltpexporter
README to point toexporterhelper
README for batching.