Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable batch sender in oltpexporter #10846

Merged
merged 22 commits into from
Aug 17, 2024
Merged

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Aug 9, 2024

Description

This PR adds opt-in support to oltp exporter for the experimental batch sender (#8122). By default batch sender is not enabled.

Similar:

Link to tracking issue

Resolves #10834

Testing

exporter/otlpexporter/config_test.go

Documentation

Updated the oltpexporter README to point to exporterhelper README for batching.

Copy link

linux-foundation-easycla bot commented Aug 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@sfc-gh-sili sfc-gh-sili reopened this Aug 10, 2024
@sfc-gh-sili sfc-gh-sili reopened this Aug 10, 2024
@sfc-gh-sili sfc-gh-sili marked this pull request as ready for review August 10, 2024 01:03
@sfc-gh-sili sfc-gh-sili requested review from a team and evan-bradley August 10, 2024 01:03
@sfc-gh-sili sfc-gh-sili reopened this Aug 10, 2024
@sfc-gh-sili sfc-gh-sili reopened this Aug 10, 2024
@sfc-gh-sili
Copy link
Contributor Author

/easycla

1 similar comment
@codeboten
Copy link
Contributor

/easycla

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (8506809) to head (50cb789).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10846   +/-   ##
=======================================
  Coverage   91.59%   91.60%           
=======================================
  Files         404      404           
  Lines       18983    18990    +7     
=======================================
+ Hits        17388    17395    +7     
  Misses       1235     1235           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just few nits

exporter/otlpexporter/factory.go Outdated Show resolved Hide resolved
exporter/otlpexporter/testdata/config.yaml Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member

The failing contrib jobs will be fixed once open-telemetry/opentelemetry-collector-contrib#34721 is merged

.chloggen/add-batching-option-to-otlp-exporter.yaml Outdated Show resolved Hide resolved
exporter/otlpexporter/testdata/config.yaml Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit d2ed276 into open-telemetry:main Aug 17, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 17, 2024
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Sep 11, 2024
**Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter.
Follows
open-telemetry/opentelemetry-collector#10846 as
we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters.

**Link to tracking Issue:** 

**Testing:** ✅ 

**Documentation:** README updated with reference to new batcher and
[concurrent batch
processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor)
in the otel-arrow repo.

---------

Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…try#34802)

**Description:** Add exportbatcher.BatcherConfig to OTel-Arrow exporter.
Follows
open-telemetry/opentelemetry-collector#10846 as
we intend to maintain parity between OTLP/gRPC and OTel-Arrow exporters.

**Link to tracking Issue:** 

**Testing:** ✅ 

**Documentation:** README updated with reference to new batcher and
[concurrent batch
processor](https://github.com/open-telemetry/otel-arrow/tree/main/collector/processor/concurrentbatchprocessor)
in the otel-arrow repo.

---------

Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otlp/exporter] Enable batcher in OTLP exporter
4 participants