Profiles support in OTLP Exporter #11131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
otlpexporter
branch
2 times, most recently
from
da2d91f
to
001e190
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11131 +/- ##
==========================================
- Coverage 91.79% 91.78% -0.02%
==========================================
Files 422 426 +4
Lines 20023 20285 +262
==========================================
+ Hits 18380 18618 +238
- Misses 1266 1283 +17
- Partials 377 384 +7 ☔ View full report in Codecov by Sentry. |
dmathieu
force-pushed
the
otlpexporter
branch
from
de932f1
to
6f56650
Compare
mx-psi
reviewed
Sep 12, 2024
dmathieu
force-pushed
the
otlpexporter
branch
4 times, most recently
from
055a6bb
to
cb0a2a3
Compare
dmathieu
force-pushed
the
otlpexporter
branch
from
cb0a2a3
to
c14ae5a
Compare
dmathieu
force-pushed
the
otlpexporter
branch
from
95a1288
to
bf81835
Compare
dmathieu
force-pushed
the
otlpexporter
branch
from
bf81835
to
8549655
Compare
mx-psi
pushed a commit
that referenced
this pull request
Sep 19, 2024
…#11215) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is part of #11131, splitting the exporterhelper module with a new `internal` submodule that holds everything shared by the signals. This is so a new `exporterhelperprofiles` module can make use of the shared structs.
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Sep 19, 2024
…open-telemetry#11215) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is part of open-telemetry#11131, splitting the exporterhelper module with a new `internal` submodule that holds everything shared by the signals. This is so a new `exporterhelperprofiles` module can make use of the shared structs.
codeboten
pushed a commit
that referenced
this pull request
Sep 19, 2024
) #### Description Split off from #11131. Prepares OTLP HTTP exporter for supporting profiles (which uses `/v1development`) Co-authored-by: Damien Mathieu <42@dmathieu.com>
dmathieu
force-pushed
the
otlpexporter
branch
3 times, most recently
from
bd6d2cd
to
d27e777
Compare
dmathieu
force-pushed
the
otlpexporter
branch
from
d27e777
to
713f25d
Compare
This was referenced Sep 20, 2024
dmathieu
added a commit
to dmathieu/opentelemetry-collector
that referenced
this pull request
Sep 20, 2024
This was authored by @dmathieu on PR open-telemetry#11131 Co-authored-by: Damien Mathieu <42@dmathieu.com>
mx-psi
pushed a commit
that referenced
this pull request
Sep 20, 2024
dmathieu
added a commit
to dmathieu/opentelemetry-collector
that referenced
this pull request
Sep 20, 2024
This was authored by @dmathieu on PR open-telemetry#11131 Co-authored-by: Damien Mathieu <42@dmathieu.com>
mx-psi
pushed a commit
that referenced
this pull request
Oct 4, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is the initial work towards #11155. This PR adds profiles marshalers to `otlptext`, which will be used in the `debugexporter` later on. To continue the work on the `debugexporter` I'd wait on the PR #11131, as it adds some shared components. <!--Describe what testing was performed and which tests were added.--> #### Testing Added `TestProfilesText`, testing the following scenarios: - `empty_profiles` - `two_profiles`
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is the initial work towards open-telemetry#11155. This PR adds profiles marshalers to `otlptext`, which will be used in the `debugexporter` later on. To continue the work on the `debugexporter` I'd wait on the PR open-telemetry#11131, as it adds some shared components. <!--Describe what testing was performed and which tests were added.--> #### Testing Added `TestProfilesText`, testing the following scenarios: - `empty_profiles` - `two_profiles`
mx-psi
added a commit
that referenced
this pull request
Oct 9, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Split off from #11131. Adds new module for consumer errors for profiles. --------- Co-authored-by: Damien Mathieu <42@dmathieu.com>
|
@dmathieu Can you fix the merge conflicts? |
|
Closing this PR, as everything it contains has been split into multiple smaller ones. |
mx-psi
added a commit
that referenced
this pull request
Oct 16, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This is extracted from #11131. It adds profiles support for the epxorterhelper, so both the otlp and otlphttp exporters can support that signal. It requires #11207✅ and #11225✅ to be merged first. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds profiles support to the OTLP exporters.
Note: This includes some commits from #11071 that were required in here too.