Fix install-tools target #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs GO111MODULE env var and the recently added addlicense tool.
pjanotti
requested review from
bogdandrutu,
flands,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 72.74% 72.74%
=======================================
Files 105 105
Lines 6094 6094
=======================================
Hits 4433 4433
Misses 1435 1435
Partials 226 226Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 24, 2019
tigrannajaryan
approved these changes
Jul 24, 2019
| @@ -97,7 +97,8 @@ vet: | |||
|
|
|||
| .PHONY: install-tools | |||
| install-tools: | |||
| go install golang.org/x/lint/golint | |||
| GO111MODULE=on go install github.com/google/addlicense | |||
There was a problem hiding this comment.
Is this needed with Go 1.12 and newer?
There was a problem hiding this comment.
Yes, this is still needed for Go 1.12 since it still has the same default as 1.11: "auto". Per golang/go#31857 it seems that it will still be needed in Go 1.13.
|
Please rebase. |
bogdandrutu
approved these changes
Jul 24, 2019
songy23
approved these changes
Jul 24, 2019
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* fix collector logs example * Update default image to 0.50.0 * Bump chart version * revert containerLog example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs GO111MODULE env var and the recently added addlicense tool.
/cc @ccaraman