Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install-tools target #195

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Fix install-tools target #195

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e855f
Fix install-tools target
Jul 24, 2019
23dcf94
Merge branch 'master' into fix-install-tools
Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ vet:

.PHONY: install-tools
install-tools:
go install golang.org/x/lint/golint
GO111MODULE=on go install github.com/google/addlicense
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed with Go 1.12 and newer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is still needed for Go 1.12 since it still has the same default as 1.11: "auto". Per golang/go#31857 it seems that it will still be needed in Go 1.13.

GO111MODULE=on go install golang.org/x/lint/golint

.PHONY: otelsvc
otelsvc:
Expand Down