Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor otlp exporter to upcoming auth changes #3288

Merged
merged 8 commits into from
May 25, 2021
Merged

Refactor otlp exporter to upcoming auth changes #3288

merged 8 commits into from
May 25, 2021

Conversation

pavankrish123
Copy link
Contributor

@pavankrish123 pavankrish123 commented May 25, 2021 •
edited
Loading

Description:
Updated oltpexporter for upcoming client auth extension changes

Link to tracking Issue:
#3287 #3282

Testing:
Unit tests

Documentation:
Unit tests

@pavankrish123 pavankrish123 requested a review from a team May 25, 2021 00:08
bogdandrutu
bogdandrutu reviewed May 25, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some comments.

exporter/otlpexporter/otlp.go Outdated Show resolved Hide resolved
exporter/otlpexporter/factory_test.go Outdated Show resolved Hide resolved
exporter/otlpexporter/config_test.go Outdated Show resolved Hide resolved
bogdandrutu
bogdandrutu approved these changes May 25, 2021
View reviewed changes
exporter/otlpexporter/factory_test.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu mentioned this pull request May 25, 2021
Merged
@bogdandrutu
Copy link
Member

@pavankrish123 lint error:

make[1]: Leaving directory '/home/runner/work/opentelemetry-collector/opentelemetry-collector'
exporter/otlpexporter/otlp.go:51: File is not `gofmt`-ed with `-s` (gofmt)
	
make[2]: *** [Makefile.Common:26: lint] Error 1

@pavankrish123
Copy link
Contributor Author

@bogdandrutu sorry missed pushing a commit - should be fixed now.

@bogdandrutu bogdandrutu merged commit a817b0f into open-telemetry:main May 25, 2021
@pavankrish123 pavankrish123 deleted the refactor/otlp branch May 25, 2021 16:44
dashpole pushed a commit to dashpole/opentelemetry-collector that referenced this pull request Jun 14, 2021
@pavankrish123 @dashpole
Refactor otlp exporter to upcoming auth changes (open-telemetry#3288)
18ea677 
* refactor otlp exporter to upcoming auth changes

* addressed review comments

* addressed review comments

* addressed review comments

* addressed review comments

* added suggestion from the review

* added suggestion from the review

* added suggestion from the review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavankrish123 @bogdandrutu