Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare components for the Client Authentication Extensions #3287

Closed
pavankrish123 opened this issue May 25, 2021 · 1 comment
Closed

Prepare components for the Client Authentication Extensions #3287

pavankrish123 opened this issue May 25, 2021 · 1 comment

Comments

@pavankrish123
Copy link
Contributor

pavankrish123 commented May 25, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

#3128 in the core introduces changes to ToDialOptions and ToClient methods to use configuration from extensions to get hold of authentication configuration for clients. However, this commit has recently been rolled back to reduce the changes needed for an individual PR in contrib ( see #3442 ).

This issue is to track moving the necessary code to the exporter/receiver/extention components 'Start' method to prepare for a more refined approach approach for integrating this new feature set.

Impacted components:

Exporters:

  • otlp
  • otlphttp
  • zipkin
  • prwe
  • jaeger

Describe the solution you'd like

I will create individual PRs based on the individual commits for the exporters above.

Describe alternatives you've considered
N/A

Additional context
This is required based on a suggestion with @bogdandrutu

This is a subtask for #3282
@pavankrish123 pavankrish123 mentioned this issue May 25, 2021
Merged
@pavankrish123
Copy link
Contributor Author

cc: @gramidt @bogdandrutu I am starting the refactoring effort on the core side exporters. I will add more.

This was referenced May 25, 2021
Merged
Merged
Merged
Merged
Merged
tigrannajaryan pushed a commit that referenced this issue May 28, 2021
@pavankrish123
Port client side authentication interfaces from PR #3128 (#3321)
7cd868d 
This PR ports the client authenticator interfaces from PR #3128  in a piece meal fashion. The interfaces are currently not used by any client configurations and are published for reviewing only. 

Plan is to modify ToClient and ToDialOptions apis once all the clients are prepared per #3287 (core and contrib side as well).

Link to tracking Issue:
#3287 #3282

Testing:
Unit tests, [manual test described (for only oidc)](#3128 (comment))
This was referenced May 28, 2021
Merged
Merged
tigrannajaryan pushed a commit that referenced this issue May 31, 2021
@pavankrish123
Refactored OpenCensus exporter to move connection into start for upco…
d1016eb 
…ming Auth changes. (#3339)

Updated OpenCensus for upcoming client auth extension changes

Link to tracking Issue:
#3287 #3282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavankrish123