Refactored PromRemoteWriteExporter to create client in Start to accomodate future update to ToClient() apis #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
May 26, 2021
bogdandrutu
approved these changes
May 26, 2021
gramidt
approved these changes
May 26, 2021
bogdandrutu
approved these changes
May 26, 2021
|
Please rebase the PR so you can pass CircleCI tests |
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…odate future update to ToClient() apis (open-telemetry#3308) * Refactored PromRemoteWriteExporter to create client in Start * fixed impi errors * Fixed per review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated PrometheusRemoteWriteExporter for upcoming client auth extension changes. Moved httpClient creation to Start method of the component. This ensures the call to ToClient() method gets access to host object which is required in the next version of ToClient() apis.
Link to tracking Issue:
#3287 #3282
Testing:
Unit tests
Documentation:
Unit tests