Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionDefaultConfigFunc should be ExtensionCreateDefaultConfigFunc #5451

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Conversation

junhaoyu-aws
Copy link
Contributor

This resolved the issue#5437, and better align with the names of following types from package component :

ExporterCreateDefaultConfigFunc
ProcessorCreateDefaultConfigFunc
ReceiverCreateDefaultConfigFunc
ExtensionDefaultConfigFunc

rice-junhaoyu and others added 2 commits June 1, 2022 14:10
ExtensionDefaultConfigFunc should be ExtensionCreateDefaultConfigFunc
@junhaoyu-aws junhaoyu-aws requested review from a team and bogdandrutu June 1, 2022 21:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@bogdandrutu
Copy link
Member

Please sign the CLA

@bogdandrutu
Copy link
Member

Add a "changelog" entry under "Deprecation"
- Deprecate ExtensionDefaultConfigFunc in favor of ExtensionCreateDefaultConfigFunc (#5451)

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #5451 (c7d41e0) into main (1aa0e5a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5451      +/-   ##
==========================================
- Coverage   90.89%   90.85%   -0.04%     
==========================================
  Files         191      191              
  Lines       11419    11421       +2     
==========================================
- Hits        10379    10377       -2     
- Misses        819      822       +3     
- Partials      221      222       +1     
Impacted Files Coverage Δ
component/build_info.go 100.00% <ø> (ø)
service/host.go 100.00% <ø> (ø)
component/extension.go 100.00% <100.00%> (ø)
service/internal/runtimeinfo/info.go 100.00% <100.00%> (ø)
service/service.go 46.42% <100.00%> (+0.64%) ⬆️
service/telemetry.go 77.55% <100.00%> (ø)
service/zpages.go 71.77% <100.00%> (+1.68%) ⬆️
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b1466...c7d41e0. Read the comment docs.

@junhaoyu-aws
Copy link
Contributor Author

Update extension.go

Thanks with this

@bogdandrutu bogdandrutu merged commit 04e92f2 into open-telemetry:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants