[builder]: Use testing.TB.TempDir instead of manually create and cleanup #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5469 +/- ##
==========================================
- Coverage 90.88% 90.81% -0.08%
==========================================
Files 192 193 +1
Lines 11425 11430 +5
==========================================
- Hits 10384 10380 -4
- Misses 819 827 +8
- Partials 222 223 +1
Continue to review full report at Codecov.
|
Fixes open-telemetry#5403 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten
approved these changes
Jun 3, 2022
codeboten
reviewed
Jun 3, 2022
There was a problem hiding this comment.
Looks like this broke CI on windows:
https://github.com/open-telemetry/opentelemetry-collector/runs/6725396224?check_suite_focus=true#step:5:38
|
@codeboten I know, but I made progress... I passed the previous error point :))) |
bogdandrutu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com