Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for Logs ostream exporter #1992

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Add example for Logs ostream exporter #1992

merged 3 commits into from
Feb 20, 2023

Conversation

MrSparc
Copy link
Contributor

@MrSparc MrSparc commented Feb 19, 2023

Fixes #1883

Changes

Add example for Logs ostream exporter

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@MrSparc MrSparc requested a review from a team February 19, 2023 02:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MrSparc / name: Ariel Machado (9e2703f)

@codecov
Copy link

codecov bot commented Feb 19, 2023 •
edited
Loading

Codecov Report

Merging #1992 (10bf603) into main (95f6c66) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         166      166           
  Lines        4662     4662           
=======================================
  Hits         4069     4069           
  Misses        593      593

marcalff
marcalff approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@lalitb lalitb merged commit eed6572 into open-telemetry:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OpenTelemetry C++ Feb 2023 release
Development

Successfully merging this pull request may close these issues.

[Logs SDK] Add example for Logs ostream exporter
3 participants
@MrSparc @lalitb @marcalff